-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing issue #91 #222
fixing issue #91 #222
Conversation
Can one of the admins verify this patch? |
@confluentinc It looks like @jdehrlich just signed our Contributor License Agreement. 👍 Always at your service, clabot |
Can someone look at this? We're running it in prod already. |
Ping |
@criccomini @jdehrlich Sorry for the slow review. LGTM. We probably should get a real cache in there rather than a collection that can continue to grow, but schemas, of all things, shouldn't really cause any problems. Thanks for the contribution! |
@ewencp assuming this will miss 3.0.1? |
@criccomini Unfortunately yes, and I apologize, that's my bad for not getting to the review earlier. |
Btw, we can cherry-pick if you want, not sure what the likelihood of a 3.0.2 is though. |
I made a Docker image with this patch applied. You can find it on Docker Hub as an automated build. |
For those that need this before the next release |
Added a map in the avrorestproducer that will cache schemas and return the id if there is one for that schema rather than reregistering.