Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-9030: Fix a typo in withGradleFile causing failed builds #848

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

vinnybod
Copy link
Member

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

This is a follow up to the previous pull request to convert the Jenkinsfile to using withGradleFile.
It looks like when it was cherry-picked to 2.4 and 2.5, it was incorrectly merged and uses [[ ]] instead of [ ].
Once this is merged, it only needs to be cherry-picked to 2.5. The rest of the release branches are correct.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

I tested this using a replay on 2.4 in Jenkins. The build is green.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@vinnybod
Copy link
Member Author

Looks like this passed, but there's an issue with the downstream check job actually returning back a success. I checked the log and it says "PASSED".

@vinnybod vinnybod merged commit 2d3d791 into 2.4 Dec 14, 2022
@vinnybod vinnybod deleted the vinnybod/DP-9030-withGradleFile-typo branch December 14, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants