fix: address review comments

confluentinc · Feb 11, 2020 · 4549caa · 4549caa
1 parent f78d49a
commit 4549caa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/config/ksql-server.properties b/config/ksql-server.properties
@@ -62,4 +62,4 @@ bootstrap.servers=localhost:9092
 # ksql.connect.worker.config=config/connect.properties
 
 # Uncomment and complete the following to enable KSQL's integration to the Confluent Schema Registry:
-ksql.schema.registry.url=http://localhost:8081
+# ksql.schema.registry.url=?
diff --git a/ksql-functional-tests/src/test/resources/query-validation-tests/protobuf.json b/ksql-functional-tests/src/test/resources/query-validation-tests/protobuf.json
@@ -47,6 +47,23 @@
         {"topic": "OUTPUT", "value": {"I": [0]}},
         {"topic": "OUTPUT", "value": {"I": []}}
       ]
+    },
+    {
+      "name": "protobuf defaults - empty struct fills defaults and nulls remain nulls",
+      "statements": [
+        "CREATE STREAM INPUT (s STRUCT<foo INTEGER>) WITH (kafka_topic='input', value_format='PROTOBUF');",
+        "CREATE STREAM OUTPUT as SELECT * FROM input;"
+      ],
+      "inputs": [
+        {"topic": "input", "value": {"s": {"foo": 0}}},
+        {"topic": "input", "value": {"s": {}}},
+        {"topic": "input", "value": {"s": null}}
+      ],
+      "outputs": [
+        {"topic": "OUTPUT", "value": {"S": {"FOO": 0}}},
+        {"topic": "OUTPUT", "value": {"S": {"FOO": 0}}},
+        {"topic": "OUTPUT", "value": {"S": null}}
+      ]
     }
   ]
 }