Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install reports 7 high severity vulnerabilities #3181

Closed
cpettitt-confluent opened this issue Aug 6, 2019 · 2 comments · Fixed by #3213
Closed

npm install reports 7 high severity vulnerabilities #3181

cpettitt-confluent opened this issue Aug 6, 2019 · 2 comments · Fixed by #3213
Assignees

Comments

@cpettitt-confluent
Copy link
Contributor

cpettitt-confluent commented Aug 6, 2019

The CONTRIBUTING.md guide recommends running npm install from the root of the KSQL repo to install commitlint. This command reports several high severity vulnerabilities in dependencies, as shown below:

% npm install

> husky@2.5.0 install /Users/xxx/projects/ksql/node_modules/husky
> node husky install

husky > Setting up git hooks
husky > Done
husky > Like husky? You can support the project on Open Collective:
husky > https://www.opencollective.com/husky 🐕

> core-js@2.6.9 postinstall /Users/xxx/projects/ksql/node_modules/core-js
> node scripts/postinstall || echo "ignore"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

npm WARN ksql No repository field.
npm WARN ksql No license field.

added 176 packages from 71 contributors and audited 453 packages in 3.293s
found 7 high severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details
@apurvam
Copy link
Contributor

apurvam commented Aug 13, 2019

This seems like a general problem with NPM right? Do you know of things we can do to address this @cpettitt-confluent ?

@cpettitt-confluent
Copy link
Contributor Author

cpettitt-confluent commented Aug 13, 2019

I can take a look. The immediate solution would be to pin to safer versions (particularly of lodash, IIRC).

But generally, npm is a risk and it doesn't seem to be buying us a lot. It also flagged a valid commit message "feat: Add SHOW TOPICS EXTENDED" because I used uppercase words. It might be better to just pull this recommendation from CONTRIBUTING or provide a custom tool written in Java or python if we see value here. It's not actually used to validate commits because I was able to commit with the message above.

@cpettitt-confluent cpettitt-confluent self-assigned this Aug 13, 2019
cpettitt-confluent added a commit to cpettitt-confluent/ksql that referenced this issue Aug 14, 2019
Fixes confluentinc#3181

Prior to this change:

```
% npm install
npm WARN ksql No repository field.
npm WARN ksql No license field.

removed 9 packages, updated 21 packages and audited 453 packages in 1.219s
found 7 high severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details
```

With this change:

```
% npm install
npm WARN ksql No repository field.
npm WARN ksql No license field.

audited 456 packages in 1.027s
found 0 vulnerabilities
```
cpettitt-confluent added a commit to cpettitt-confluent/ksql that referenced this issue Aug 14, 2019
Fixes confluentinc#3181

Prior to this change:

```
% npm install
npm WARN ksql No repository field.
npm WARN ksql No license field.

removed 9 packages, updated 21 packages and audited 453 packages in 1.219s
found 7 high severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details
```

With this change:

```
% npm install
npm WARN ksql No repository field.
npm WARN ksql No license field.

audited 456 packages in 1.027s
found 0 vulnerabilities
```
cpettitt-confluent added a commit that referenced this issue Aug 14, 2019
#3213)

Fixes #3181

Prior to this change:

```
% npm install
npm WARN ksql No repository field.
npm WARN ksql No license field.

removed 9 packages, updated 21 packages and audited 453 packages in 1.219s
found 7 high severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details
```

With this change:

```
% npm install
npm WARN ksql No repository field.
npm WARN ksql No license field.

audited 456 packages in 1.027s
found 0 vulnerabilities
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants