Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on a single version for the avro-random-genator #1507

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Standardize on a single version for the avro-random-genator #1507

merged 1 commit into from
Jun 28, 2018

Conversation

apurvam
Copy link
Contributor

@apurvam apurvam commented Jun 28, 2018

Description

We use multiple versions of the avro random generator right now. Let's standardize on one.

Testing done

PR builder gives a green build.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@apurvam apurvam requested review from mohnishbasha and a team June 28, 2018 02:15
mohnishbasha
mohnishbasha approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@mohnishbasha mohnishbasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets get the pr build pass.

@mohnishbasha mohnishbasha merged commit 871bc0c into confluentinc:master Jun 28, 2018
apurvam added a commit to apurvam/ksql that referenced this pull request Jun 28, 2018
@apurvam
Standardize on a single version for the avro-random-genator (confluen…
bdfa062 
…tinc#1507)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohnishbasha mohnishbasha mohnishbasha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apurvam @mohnishbasha