Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSQL-2278: Ensure all SR props are passed where needed #2584

Merged
merged 1 commit into from
Mar 20, 2019
Merged

KSQL-2278: Ensure all SR props are passed where needed #2584

merged 1 commit into from
Mar 20, 2019

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented Mar 19, 2019 •
edited
Loading

Security-related SR props were not being passed where needed for ksqldata-gen

@rayokota rayokota requested a review from a team as a code owner March 19, 2019 22:31
@ghost
Copy link

ghost commented Mar 19, 2019

@confluentinc It looks like @rayokota just signed our Contributor License Agreement. 👍

Always at your service,

clabot

spena
spena approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spena spena requested a review from a team March 20, 2019 15:01
hjafarpour
hjafarpour approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rayokota rayokota merged commit a12a285 into confluentinc:5.1.x Mar 20, 2019
@rayokota rayokota deleted the KSQL-2278 branch March 20, 2019 17:54
@rayokota rayokota mentioned this pull request Apr 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

@hjafarpour hjafarpour hjafarpour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayokota @spena @hjafarpour