Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DESCRIBE now works for sources with decimal types (fixes #3059) #3083

Merged
merged 1 commit into from
Jul 16, 2019
Merged

fix: DESCRIBE now works for sources with decimal types (fixes #3059) #3083

merged 1 commit into from
Jul 16, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Jul 15, 2019 •
edited

Description

(#3059) DESCRIBE functionality does not work with DECIMAL types. This fixes that and adds unit test coverage.

Testing done

Unit test coverage.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner July 15, 2019 23:53
vcrfxia
vcrfxia approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @agavra !

@vcrfxia vcrfxia requested a review from a team July 16, 2019 03:11
@agavra agavra merged commit 0eaa101 into confluentinc:master Jul 16, 2019
@agavra agavra deleted the describe_decimal branch July 16, 2019 15:32
@agavra agavra mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agavra @vcrfxia