Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DESCRIBE now works for sources with decimal types (fixes #3059) #3083

Merged
merged 1 commit into from
Jul 16, 2019
Merged

fix: DESCRIBE now works for sources with decimal types (fixes #3059) #3083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ksql-rest-app/src/main/java/io/confluent/ksql/rest/util/EntityUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import io.confluent.ksql.schema.connect.SchemaWalker;
import io.confluent.ksql.schema.ksql.LogicalSchema;
import io.confluent.ksql.schema.ksql.SqlBaseType;
import io.confluent.ksql.util.DecimalUtil;
import java.util.ArrayList;
import java.util.List;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -86,6 +87,12 @@ public SchemaInfo visitString(final Schema schema) {
return primitive(SqlBaseType.STRING);
}

@Override
public SchemaInfo visitBytes(final Schema schema) {
DecimalUtil.requireDecimal(schema);
return new SchemaInfo(SqlBaseType.DECIMAL, null, null);
}

public SchemaInfo visitArray(final Schema schema, final SchemaInfo element) {
return new SchemaInfo(SqlBaseType.ARRAY, null, element);
}
Expand Down
2 changes: 2 additions & 0 deletions ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/TemporaryEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import io.confluent.ksql.services.ServiceContext;
import io.confluent.ksql.services.TestServiceContext;
import io.confluent.ksql.statement.ConfiguredStatement;
import io.confluent.ksql.util.DecimalUtil;
import io.confluent.ksql.util.KsqlConfig;
import io.confluent.ksql.util.timestamp.MetadataTimestampExtractionPolicy;
import io.confluent.rest.RestConfig;
Expand All @@ -50,6 +51,7 @@ public class TemporaryEngine extends ExternalResource {

public static final LogicalSchema SCHEMA = LogicalSchema.of(SchemaBuilder.struct()
.field("val", Schema.OPTIONAL_STRING_SCHEMA)
.field("val2", DecimalUtil.builder(2, 1).build())
.build());

private MutableMetaStore metaStore;
Expand Down