Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: `COLLECT_LIST` can now be applied to tables #3104

Merged
merged 2 commits into from Jul 23, 2019

Conversation

@vcrfxia
Copy link
Contributor

commented Jul 20, 2019

Description

Same as #3093, but retargeted at an earlier branch.

(The only difference between these diffs and the ones in #3093 are that the old query translation test framework (used in 5.1) required all messages to have timestamps. I will remove these timestamps from 5.2 and later via a manual merge after this PR is submitted.)

Testing done

Updated unit tests and added query translation tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from confluentinc/ksql as a code owner Jul 20, 2019

@vcrfxia vcrfxia referenced this pull request Jul 20, 2019
0 of 2 tasks complete
@agavra
agavra approved these changes Jul 22, 2019
Copy link
Contributor

left a comment

Thanks @vcrfxia

@agavra agavra requested a review from confluentinc/ksql Jul 22, 2019

@vcrfxia vcrfxia merged commit c239785 into confluentinc:5.1.x Jul 23, 2019

2 checks passed

Semantic Pull Request ready to be squashed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@vcrfxia vcrfxia deleted the vcrfxia:collect_list_5.1 branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.