Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: COLLECT_LIST can now be applied to tables #3104

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Jul 20, 2019

Description

Same as #3093, but retargeted at an earlier branch.

(The only difference between these diffs and the ones in #3093 are that the old query translation test framework (used in 5.1) required all messages to have timestamps. I will remove these timestamps from 5.2 and later via a manual merge after this PR is submitted.)

Testing done

Updated unit tests and added query translation tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner July 20, 2019 04:56
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vcrfxia

@agavra agavra requested a review from a team July 22, 2019 20:27
@vcrfxia vcrfxia merged commit c239785 into confluentinc:5.1.x Jul 23, 2019
@vcrfxia vcrfxia deleted the collect_list_5.1 branch July 23, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants