Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: robin's requested message changes (MINOR) #4021

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

big-andy-coates
Copy link
Contributor

Description

fixes: #3521

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested a review from a team as a code owner December 2, 2019 23:15
@big-andy-coates
Copy link
Contributor Author

So minor... merging without review.

@big-andy-coates big-andy-coates merged commit 422a2e3 into confluentinc:master Dec 3, 2019
@big-andy-coates big-andy-coates deleted the pull_error_2 branch December 3, 2019 08:46
@@ -59,7 +59,7 @@
+ System.lineSeparator()
+ System.lineSeparator()
+ "Note: Persistent queries, e.g. `CREATE TABLE AS ...`, have an implicit "
+ "`EMIT CHANGES`, but we recommend adding `EMIT CHANGES` to these statements.";
+ "`EMIT CHANGES`, but we recommend adding `EMIT CHANGES` to these statements for clarify.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: clarify -> clarity? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KSQL 5.4 syntax changes message improvements
2 participants