Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show topics doesn't display topics with different casing #4159

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

stevenpyzhang
Copy link
Member

Description

#1284
Because we lower case all the keys when filtering out internal topics in the return, Kafka topics that differ only by casing will get overwritten in the list returned.

I'm not sure exactly why the .toLowerCase() is present, it's been there since late 2017 though.

Testing done

Unit Test
Did a show topics command in the CLI

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@stevenpyzhang stevenpyzhang requested a review from a team December 17, 2019 20:49
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - I wonder why we did that...

@stevenpyzhang stevenpyzhang merged commit 0ac8747 into confluentinc:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants