Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: immutability in some more classes (MINOR) #4179

Merged
merged 1 commit into from
Dec 20, 2019
Merged

fix: immutability in some more classes (MINOR) #4179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ksql-execution/src/main/java/io/confluent/ksql/execution/codegen/CodeGenSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import org.apache.kafka.connect.data.ConnectSchema;
import org.apache.kafka.connect.data.Schema;

@Immutable
Expand Down Expand Up @@ -239,14 +240,14 @@ public String toString() {
@Immutable
public static final class SchemaArgumentSpec extends BaseArgumentSpec {

private final Schema schema;
private final ConnectSchema schema;

SchemaArgumentSpec(
String name,
Schema schema
) {
super(name, Schema.class);
this.schema = requireNonNull(schema, "schema");
this.schema = (ConnectSchema) requireNonNull(schema, "schema").schema();
}

@Override
Expand Down
1 change: 1 addition & 0 deletions ...ion/src/main/java/io/confluent/ksql/execution/expression/tree/CreateStructExpression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ public int hashCode() {
return Objects.hash(fields);
}

@Immutable
public static class Field {
private final String name;
private final Expression value;
Expand Down