Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: immutability in some more classes (MINOR) #4179

Merged
merged 1 commit into from
Dec 20, 2019
Merged

fix: immutability in some more classes (MINOR) #4179

merged 1 commit into from
Dec 20, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Dec 20, 2019

Description

see description

Testing done

ran the ImmutabilityTest

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner December 20, 2019 17:57
big-andy-coates
big-andy-coates approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@big-andy-coates big-andy-coates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @agavra

Can you also get to the bottom of why the build wasn't failing before this fix, please?

@agavra agavra merged commit cbd3bab into confluentinc:master Dec 20, 2019
@agavra agavra deleted the fix_immut branch December 20, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@big-andy-coates big-andy-coates big-andy-coates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agavra @big-andy-coates