Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unncecessary @AfterClass cleanup in LagReportingAgentFunctionalTest which is causing flakiness #4429

Merged
merged 2 commits into from Feb 3, 2020
Merged

fix: Remove unncecessary @AfterClass cleanup in LagReportingAgentFunctionalTest which is causing flakiness #4429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f60f0ce
fix: Remove unncecessary @AfterClass cleanup in LagReportingAgentFunc…
AlanConfluent Feb 3, 2020
cc2b8ea
More cleanup
AlanConfluent Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions ...app/src/test/java/io/confluent/ksql/rest/integration/LagReportingAgentFunctionalTest.java
View file
Open in desktop
Expand Up @@ -68,8 +68,6 @@ public class LagReportingAgentFunctionalTest {

private static final KsqlHostEntity HOST0 = new KsqlHostEntity("localhost", 8088);
private static final KsqlHostEntity HOST1 = new KsqlHostEntity("localhost", 8089);
private static final String HOST0_STR = "localhost:8088";
private static final String HOST1_STR = "localhost:8089";
private static final IntegrationTestHarness TEST_HARNESS = IntegrationTestHarness.build();
private static final TestKsqlRestApp REST_APP_0 = TestKsqlRestApp
.builder(TEST_HARNESS::kafkaBootstrapServers)
Expand All @@ -86,7 +84,6 @@ public class LagReportingAgentFunctionalTest {
// Lag Reporting
.withProperty(KsqlRestConfig.KSQL_LAG_REPORTING_ENABLE_CONFIG, true)
.withProperty(KsqlRestConfig.KSQL_LAG_REPORTING_SEND_INTERVAL_MS_CONFIG, 3000)
.withProperties(ClientTrustStore.trustStoreProps())
.build();
private static final TestKsqlRestApp REST_APP_1 = TestKsqlRestApp
.builder(TEST_HARNESS::kafkaBootstrapServers)
Expand All @@ -103,7 +100,6 @@ public class LagReportingAgentFunctionalTest {
// Lag Reporting
.withProperty(KsqlRestConfig.KSQL_LAG_REPORTING_ENABLE_CONFIG, true)
.withProperty(KsqlRestConfig.KSQL_LAG_REPORTING_SEND_INTERVAL_MS_CONFIG, 3000)
.withProperties(ClientTrustStore.trustStoreProps())
.build();

@ClassRule
Expand Down Expand Up @@ -135,12 +131,6 @@ public static void setUpClass() {
);
}

@AfterClass
public static void tearDownClass() {
REST_APP_0.closePersistentQueries();
REST_APP_0.dropSourcesExcept();
}

@Test(timeout = 60000)
public void shouldExchangeLags() {
// Given:
Expand Down