fix: add functional-test dependencies to Docker module

[colinhicks]

Description

Dependencies required by ksql-test-runner are not present in the artifacts copied to Docker images. cf. #4584

Testing done

I built the Docker image locally via
mvn -Pdocker package -pl ksql-docker -DskipTests -Dspotbugs.skip -Dcheckstyle.skip -Ddockerfile.skip=false -Dskip.docker.build=false -Ddocker.upstream-tag=master-latest -Ddocker.tag=local.build -Ddocker.upstream-registry='368821881613.dkr.ecr.us-west-2.amazonaws.com/'

Then I ran the repro steps in #4584, using the placeholder/confluentinc/ksql-docker:local.build image built above.

The reported exception was not thrown.

Reviewer checklist

• Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
• Ensure relevant issues are linked (description should include text like "Fixes #")

[ghost]

@confluentinc It looks like @colinhicks just signed our Contributor License Agreement. 👍

Always at your service,

clabot

[agavra]

I'm wondering if instead of depending directly on hamcrest, why not depend on the ksql-package module? That way anything else will get copied over if we ever add it.

[colinhicks]

@agavra fair point. I guess we have this line in the package pom because it needs to be built after all source modules https://github.com/confluentinc/ksql/blob/master/ksql-package/pom.xml#L32.

    <!-- Dependencies are required only to ensure this module is built last. -->

But I'm not familiar enough with the packaging details to say that ksql-package does not strictly need to go last.

A second consideration is that ksql-package brings in other net-new deps. I suppose it's not a goal at this point to aggressively limit the image size?

[agavra]

@colinhicks - that actually makes sense - let's go down this approach for now

[apurvam]

Thanks for taking care of this @colinhicks

cc @vpapavas

[colinhicks]

Btw, I couldn't sync 5.5.x to master after merging this PR, as I don't have push permissions.

Thanks for the review!