feat: Simple perf tool for new API #4590
Conversation
purplefox
force-pushed
the
perf_runner
branch
2 times, most recently
from
5f24f27
to
873117c
Compare
There was a problem hiding this comment.
Hey @purplefox
Why are we not just using JMH here? Feels like we're reinventing the wheel...
Hopefully, in the future, we'll have our existing JHM tests hooked up so that major degredations in performance fail the build. It would be nice if we got these tests also failing the build without any additional work.
| protected WebClient client; | ||
| protected Server server; | ||
|
|
||
| protected volatile Throwable throwable; |
There was a problem hiding this comment.
nit: private? There's a protected setter method...
| protected void endRun() throws Exception { | ||
| sendStream.pause(); | ||
|
|
||
| Thread.sleep(500); |
There was a problem hiding this comment.
Why the sleep with a magic number of ms? Such sleeps in tests are a code smell and often result in intermittent failures.
| protected void endRun() throws Exception { | ||
| pullQueryEndpoints.closePublishers(); | ||
|
|
||
| Thread.sleep(500); |
There was a problem hiding this comment.
As above, why the sleep with a magic number of ms? Such sleeps in tests are a code smell and often result in intermittent failures.
JMH is designed for microbenchmarking of short lived invocations, not really suitable for what we're doing here |
purplefox
force-pushed
the
perf_runner
branch
from
fa54920
to
b0a636f
Compare
Description
Implements #4279
This is a stacked PR so please just review commits from "perf runner" and later
This PR introduces a simple perf tool for rough perf testing of our new API.
It's a simple tool that does not pretend to be perfect or a general purpose performance tool, but it's really useful for quickly running some tests in your IDE to get a rough idea of the overhead of the new API machinery. This can be used as first pass for tuning the server.
There's a base class called PerfRunner where all the magic happens. Then you subclass this for your particular test.
The PR also contains some changes to various buffer sizes and the like, tuned by running this perf tool.
Testing done
Reviewer checklist