Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ksqlDB docs for Protobuf support (DOCS-3559) #4786

Merged
merged 2 commits into from
Mar 17, 2020
Merged

docs: update ksqlDB docs for Protobuf support (DOCS-3559) #4786

merged 2 commits into from
Mar 17, 2020

Conversation

JimGalasyn
Copy link
Member

I updated the docs on the naive assumption that Protobuf in ksqlDB acts just like Avro. Please comment where/if this isn't true!

@JimGalasyn JimGalasyn requested a review from a team as a code owner March 16, 2020 23:08
@agavra
Copy link
Contributor

agavra commented Mar 17, 2020

Thanks @JimGalasyn - I've been meaning to get around to doing this but have been swamped. I'll take a look at this tomorrow morning

Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JimGalasyn!

@JimGalasyn
Copy link
Member Author

Thanks for the review, @agavra !

@JimGalasyn JimGalasyn merged commit 359be30 into confluentinc:master Mar 17, 2020
@JimGalasyn JimGalasyn deleted the docs-3559 branch March 17, 2020 18:32
@vcrfxia vcrfxia mentioned this pull request Mar 18, 2020
JimGalasyn added a commit that referenced this pull request Apr 24, 2020
)

* docs: update ksqlDB docs for Protobuf support (DOCS-3559)

* docs: add JSON_SR to lists and add a note  (DOCS-3559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants