Commits on Apr 22, 2020

1. fix: include lower-case identifiers among those that need quotes (con… …

   …fluentinc#3723)
   
   IdentifierUtils::needsQuotes is used by various code that formats SQL text to
   decide what identifiers to wrap in quotes. Before this change, this just included
   reserved identifiers. However, identifiers that include lower-case characters should
   also be quoted. Otherwise, when the parser parses them it will convert them to
   upper-case. So this patch changes needsQuotes to check for lower-case characters.
   
   For schema inference, we don't want to quote column names generated from lower-case
   avro schema fields. To handle this, this patch adds IdentifierUtils.isValid, that
   only returns true if the identifier is valid (parsable). Schema inference uses this
   to only quote invalid identifiers.

   

   rodesai authored and stevenpyzhang committed Apr 22, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 219dbce
   • Browse repository at this point

   Copy the full SHA

   219dbce View commit details

   Browse the repository at this point in the history