feat: support CREATE OR REPLACE w/ config guard but w/o restrictions #5766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the work of allowing us to issue
CREATE OR REPLACE <source>and it will replace the source with the new query. It does not do any type of validation, which may be extraordinarily dangerous, so it is disabled by default. Future PRs will introduce guardrails to ensure that the compatibility is validated.The funcitonal change is only a few lines in
EngineContextandMetaStoreImpl, most the hard work was done in the preivous pr (#5710) to reuse queryIds.Testing done
The main test is
ReplaceIntTest, the rest are just updated legacy tests.Reviewer checklist