feat: add config for suppress buffer #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @nae701 hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
agavra
approved these changes
Aug 7, 2020
ksqldb-common/src/main/java/io/confluent/ksql/util/KsqlConfig.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/planner/LogicalPlanner.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/test/java/io/confluent/ksql/planner/LogicalPlannerTest.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/test/java/io/confluent/ksql/planner/LogicalPlannerTest.java
Show resolved
Hide resolved
ksqldb-streams/src/main/java/io/confluent/ksql/execution/streams/TableSuppressBuilder.java
Outdated
Show resolved
Hide resolved
ksqldb-streams/src/main/java/io/confluent/ksql/execution/streams/TableSuppressBuilder.java
Outdated
Show resolved
Hide resolved
This was referenced Aug 12, 2020
2 tasks
sarwarbhuiyan
pushed a commit
to sarwarbhuiyan/ksql
that referenced
this pull request
Sep 4, 2020
* fix: add config to disable suppress andbound buffer size * fix: add suppress feature flag and buffer configs * fix: fix checkstyle * fix: fix checstyle violation * fix: address feedback * fix: add commmit suggestions * fix: import order * test: fix tablesuppressbuilder test * test: fix logical planner test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What behavior do you want to change, why, how does your patch achieve the changes?
Adding configs to enable/disable suppress as well as to bound suppress buffer size
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Unit tests and qtts have been added
Reviewer checklist