refactor: Call the correct pull/push query validator

[spena]

Description

I found in the QueryAnalyzer code an invalid validator call to pull/push queries.

See the first QueryAnalyzer that calls another QueryAnalyzer constructor with push, then pull validators. But the constructor accepts pull, then push validators. Also the if condition in the analyze is calling a different validator.

public QueryAnalyzer(
      final MetaStore metaStore,
      final String outputTopicPrefix,
      final Set<SerdeOption> defaultSerdeOptions
  ) {
    this(
        new Analyzer(metaStore, outputTopicPrefix, defaultSerdeOptions),
        new PushQueryValidator(),
        new PullQueryValidator()
    );
  }

@VisibleForTesting
  QueryAnalyzer(
      final Analyzer analyzer,
      final QueryValidator pullQueryValidator,
      final QueryValidator pushQueryValidator
  ) {
    ...
  }

public Analysis analyze(...) {
     ...
     if (query.isPullQuery()) {
      pushQueryValidator.validate(analysis);
    } else {
      pullQueryValidator.validate(analysis);
    }
}

This PR fixes the constructor call and if condition to call the correct validator.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

• Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
• Ensure relevant issues are linked (description should include text like "Fixes #")

[big-andy-coates]

LGTM