Json keys #6292
Merged
Json keys #6292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip: confluentinc#6215 fixes: confluentinc#6214 First pass of adding QTT tests around the JSON key format, including adding tests for `DECIMAL` and `BOOLEAN` types, which is the first time they've been used as a key column type. The test around a JSON `DOUBLE` key is currently disabled, due to a limitation of QTT which reads doubles as `BigDecimal`. Code works, just need to enhance QTT to do the right thing. Commit includes a fix in `SerdeOptionsFactory` to ensure no key unwrapping is set if there is no key, plus refactored `SerdeOptionsFactory`, combining the two public methods.
vcrfxia
approved these changes
Sep 28, 2020
ksqldb-functional-tests/src/test/resources/query-validation-tests/json.json
Show resolved
Hide resolved
Conflicting files ksqldb-engine/src/main/java/io/confluent/ksql/ddl/commands/CreateSourceFactory.java ksqldb-engine/src/main/java/io/confluent/ksql/planner/LogicalPlanner.java ksqldb-engine/src/main/java/io/confluent/ksql/schema/ksql/inference/SchemaRegisterInjector.java ksqldb-engine/src/main/java/io/confluent/ksql/serde/SerdeOptionsFactory.java ksqldb-engine/src/main/java/io/confluent/ksql/structured/SchemaKGroupedStream.java ksqldb-engine/src/test/java/io/confluent/ksql/serde/SerdeOptionsFactoryTest.java ksqldb-engine/src/test/java/io/confluent/ksql/structured/SchemaKGroupedStreamTest.java ksqldb-functional-tests/src/main/java/io/confluent/ksql/test/tools/TestCaseBuilderUtil.java
This was referenced Sep 30, 2020
See #6345 for a test on converting between formats and where the key SQL type isn't supported by the sink key schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
part of: #6215
fixes: #6214
First pass of adding QTT tests around the JSON key format, including adding tests for
DECIMALandBOOLEANtypes, which is the first time they've been used as a key column type.Commit includes a fix in
SerdeOptionsFactoryto ensure no key unwrapping is set if there is no key, plus refactoredSerdeOptionsFactory, combining the two public methods.Testing done
usual
Reviewer checklist