fix: KeyQueryMetadata not available on Pull query after stream is created #6633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated A KeyQueryMetadata.NOT_AVAILABLE is usually caused when resources (hosts/streams) are not ready to access the state store. This fix allows clients to retry the pull query when such state is found.
spena
force-pushed
the
fix_pull_query_issue
branch
from
b8decfa
to
9882f19
Compare
agavra
reviewed
Nov 17, 2020
| @@ -366,6 +366,18 @@ | |||
| public static final String KSQL_VARIABLE_SUBSTITUTION_ENABLE_DOC | |||
| = "Enable variable substitution on SQL statements."; | |||
|
|
|||
| public static final String KSQL_RETRIABLE_REQUESTS_MAX_RETRIES | |||
There was a problem hiding this comment.
I haven't looked at the code yet, but I wanted to comment that I don't think we should set the default behavior to retry or sleep. For pull queries, I suspect a better default behavior is to fail fast than to hang - so that the user can decide whether they want to retry or not. What's important is to make sure that we have a good error message returned to the user.
2 tasks
|
Closing this now the issue is fixed here: #6709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6249
A KeyQueryMetadata.NOT_AVAILABLE is usually caused when resources (hosts/streams) are not ready to access the state store. You can see this error when executing a pull query right after the stream is created. It takes some time for the streams to create the materialization in all the hosts.
To fix this issue, the clients must retry the pull query after some time in order to access the state store. This PR allows clients to retry requests that are marked as
ERROR_CODE_RESOURCE_NOT_READYfor a maximum number of retries and for some waiting time between retries.By default, a request will wait for 500ms between retries and up to 10 retries. Users can configure this with the following config:
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist