feat: timestamp support - casting, comparisons and serde #6806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaralim
changed the title
jzaralim
changed the title
spena
reviewed
Jan 5, 2021
ksqldb-common/src/main/java/io/confluent/ksql/function/types/TimestampType.java
Outdated
Show resolved
Hide resolved
| @@ -62,13 +63,16 @@ | |||
| private static final Schema CONNECT_BIGINT_SCHEMA = SchemaBuilder.int64().optional().build(); | |||
| private static final Schema CONNECT_DOUBLE_SCHEMA = SchemaBuilder.float64().optional().build(); | |||
| private static final Schema CONNECT_STRING_SCHEMA = SchemaBuilder.string().optional().build(); | |||
| private static final Schema CONNECT_TIMESTAMP_SCHEMA = | |||
| SchemaBuilder.int64().name("org.apache.kafka.connect.data.Timestamp").version(1).optional().build(); | |||
There was a problem hiding this comment.
It's a part of the schema from the Timestamp class. This ended up being replaced by the builder from the Timestamp class though.
ksqldb-engine-common/src/main/java/io/confluent/ksql/schema/ksql/SqlTimestamps.java
Outdated
Show resolved
Hide resolved
| + "Partials are also supported, for example \"2020-05-26\""; | ||
|
|
||
| private static final StringToTimestampParser PARSER = | ||
| new StringToTimestampParser(KsqlConstants.DATE_TIME_PATTERN); | ||
|
|
||
| public Timestamp parseToTimestamp(final String text) { | ||
| return new Timestamp(parse(text)); |
There was a problem hiding this comment.
parse is gonna parse strings with timezones if the string contains +0200 for instance. Isn't this going to cause an issue?
ksqldb-engine/src/test/java/io/confluent/ksql/engine/generic/GenericExpressionResolverTest.java
Show resolved
Hide resolved
...b-execution/src/test/java/io/confluent/ksql/execution/codegen/helpers/CastEvaluatorTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+128
to
+132
| final Long longVal = Long.valueOf(spec.toString()); | ||
| if (Timestamp.LOGICAL_NAME.equals(schema.name())) { | ||
| return Timestamp.toLogical(schema, (Long) spec); | ||
| return new java.sql.Timestamp(longVal); | ||
| } | ||
| return Long.valueOf(spec.toString()); | ||
| return longVal; |
There was a problem hiding this comment.
Does it need changes in connectToSpec?
I see this code in that method:
case INT64:
if (Timestamp.LOGICAL_NAME.equals(schema.name())) {
return Timestamp.fromLogical(schema, (Date) data);
}
There was a problem hiding this comment.
connectToSpec is used for checking the values in streams in functional tests. These values are verified against values in a json file and since json files cannot store timestamp objects, comparing the millis is the only way to check timestamp values.
ksqldb-serde/src/main/java/io/confluent/ksql/serde/delimited/KsqlDelimitedDeserializer.java
Outdated
Show resolved
Hide resolved
ksqldb-serde/src/test/java/io/confluent/ksql/serde/json/KsqlJsonSerializerTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First pass at adding timestamp type support (#4148). This PR includes casting between strings and timestamps, comparisons and JSON/Avro/Delimited serde.
It looks like a lot of files, but most are tests or changes that involve adding timestamp to a list of types. All the other files can be broken down as follows:
Parsing
Casting
Comparisons
Serde
Not included in this PR:
google.protobuf.Timestampis registered in Schema Registry.Testing done
QTT and unit tests
Reviewer checklist