Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrations): implement create command #7133

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Mar 2, 2021

Description

The migrations create command creates an empty migrations file, of the appropriate filename format.

Testing done

Unit + integration.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner March 2, 2021 16:44
return true;
}

final Optional<String> existingFile;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also do this check in apply, since validate only checks for duplicate versions for versions that have already been migrated. Currently, apply will still run if there are two unmigrated files with the same version number. This can be done in a follow-up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm working on a follow-up with some changes to apply right now anyway, so I'll slip this into my next PR. Good call!

@vcrfxia vcrfxia merged commit c91e23c into confluentinc:master Mar 2, 2021
@vcrfxia vcrfxia deleted the migrations-create branch March 2, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants