Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the DATE and TIME sql types #7641

Merged
merged 2 commits into from
Jun 8, 2021
Merged

feat: add the DATE and TIME sql types #7641

merged 2 commits into from
Jun 8, 2021

Conversation

jzaralim
Copy link
Contributor

@jzaralim jzaralim commented Jun 5, 2021

Description

Adds the DATE and TIME sql types to SqlBaseType, SqlTypes etc.

Testing done

Updated the related unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner June 5, 2021 02:50
spena
spena approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzaralim jzaralim merged commit 661f198 into confluentinc:master Jun 8, 2021
@jzaralim jzaralim deleted the date-time-types branch June 8, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzaralim @spena