Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky version checker test by using simpler mock #7863

Merged
merged 1 commit into from
Jul 26, 2021
Merged

test: fix flaky version checker test by using simpler mock #7863

merged 1 commit into from
Jul 26, 2021

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Jul 23, 2021

Description

This does two things:

  1. fixes a flaky test by using a mock wire instead of spinning up an entire mocked proxy server
  2. removes a dependency that has historically caused us some grief as it depends on specific netty versions

Rejoice!

Testing done

Test would fail 1/10 runs locally before this change, didn't fail with 1k runs afterwards.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner July 23, 2021 00:39
lct45
lct45 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@lct45 lct45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM from what I can tell 😉 thanks @agavra

@agavra agavra merged commit 95c9245 into confluentinc:master Jul 26, 2021
@agavra agavra deleted the fix_flaky_version_checker branch July 26, 2021 22:15
jzaralim pushed a commit that referenced this pull request Nov 22, 2021
@agavra
test: fix flaky version checker test by using simpler mock (#7863)
d2612c0
jzaralim pushed a commit that referenced this pull request Nov 22, 2021
@agavra
test: fix flaky version checker test by using simpler mock (#7863) (#…
e06f106 
…8407)

Co-authored-by: Almog Gavra <almog@confluent.io>
jzaralim pushed a commit that referenced this pull request Nov 23, 2021
fix: port changes from #7863 to 5.4.x
637e298
@jzaralim jzaralim mentioned this pull request Nov 23, 2021
Merged
2 tasks
jzaralim pushed a commit that referenced this pull request Nov 23, 2021
fix: port changes from #7863 to 5.4.x (#8409)
25c9ca5 
* fix: port changes from #7863 to 5.4.x

* remove two lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lct45 lct45 lct45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agavra @lct45