Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cherry-pick #7863 to the 5.5.x branch #8407

Merged
merged 1 commit into from
Nov 22, 2021
Merged

test: cherry-pick #7863 to the 5.5.x branch #8407

merged 1 commit into from
Nov 22, 2021

Conversation

jzaralim
Copy link
Contributor

Description

After the netty version was bumped on 5.5.x, the version checker test started failing. This PR ports a fix that makes the test not dependent on specific netty versions.

Testing done

The test passes locally

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner November 22, 2021 22:44
@jzaralim jzaralim merged commit e06f106 into 5.5.x Nov 22, 2021
@jzaralim jzaralim deleted the netty branch November 22, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants