-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: revert GRACE keyword in Joins #8020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f889d47.
JimGalasyn
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will need to be cherry-picked to 7.0.x
before the 0.21.x-ksqldb
branch cut.
Jenkins fails due to some dependencies, but this is only docs. I will merge it as none of those errors are related. |
JimGalasyn
added a commit
that referenced
this pull request
Aug 19, 2021
JimGalasyn
added a commit
that referenced
this pull request
Aug 19, 2021
JimGalasyn
added a commit
that referenced
this pull request
Aug 19, 2021
spena
pushed a commit
that referenced
this pull request
Oct 6, 2021
spena
added a commit
that referenced
this pull request
Oct 7, 2021
…8236) Re-enable stream-stream left/outer joins fixes again. * Revert "Revert GRACE keyword in Joins (#8020) (#8027)" This reverts commit dac6e38. * Revert "chore: revert GRACE PERIOD from joins (#8028)" This reverts commit c17ce67. * Revert "chore: revert call to ofTimeAndGracePeriod() (#8047)" This reverts commit 4c54980.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What behavior do you want to change, why, how does your patch achieve the changes?
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist