Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revert GRACE keyword in Joins #8020

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Conversation

spena
Copy link
Member

@spena spena commented Aug 19, 2021

Description

What behavior do you want to change, why, how does your patch achieve the changes?

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena requested review from JimGalasyn and a team as code owners August 19, 2021 16:46
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will need to be cherry-picked to 7.0.x before the 0.21.x-ksqldb branch cut.

@spena
Copy link
Member Author

spena commented Aug 19, 2021

Jenkins fails due to some dependencies, but this is only docs. I will merge it as none of those errors are related.

@spena spena merged commit e314731 into 0.20.0-ksqldb Aug 19, 2021
@spena spena deleted the remove_grace_join_references branch August 19, 2021 19:52
JimGalasyn added a commit that referenced this pull request Aug 19, 2021
Co-authored-by: Sergio Peña <sergio@confluent.io>
JimGalasyn added a commit that referenced this pull request Aug 19, 2021
Co-authored-by: Sergio Peña <sergio@confluent.io>
JimGalasyn added a commit that referenced this pull request Aug 19, 2021
Co-authored-by: Sergio Peña <sergio@confluent.io>
@JimGalasyn JimGalasyn changed the title Revert GRACE keyword in Joins docs: revert GRACE keyword in Joins Aug 19, 2021
spena pushed a commit that referenced this pull request Oct 6, 2021
Re-enable stream-stream left/outer joins fixes again.

This reverts commit dac6e38.
spena added a commit that referenced this pull request Oct 7, 2021
…8236)

Re-enable stream-stream left/outer joins fixes again.

* Revert "Revert GRACE keyword in Joins (#8020) (#8027)"
This reverts commit dac6e38.

* Revert "chore: revert GRACE PERIOD from joins (#8028)"
This reverts commit c17ce67.

* Revert "chore: revert call to ofTimeAndGracePeriod() (#8047)"
This reverts commit 4c54980.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants