chore: revert GRACE PERIOD syntax from stream-stream joins #8028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
changed the title
guozhangwang
approved these changes
Aug 23, 2021
|
@spena we should have reverted this in the 7.0 branch, not |
spena
added a commit
that referenced
this pull request
Aug 24, 2021
2 tasks
2 tasks
spena
pushed a commit
that referenced
this pull request
Oct 6, 2021
Re-enable stream-stream left/outer joins fixes again. This reverts commit c17ce67.
spena
added a commit
that referenced
this pull request
Oct 7, 2021
…8236) Re-enable stream-stream left/outer joins fixes again. * Revert "Revert GRACE keyword in Joins (#8020) (#8027)" This reverts commit dac6e38. * Revert "chore: revert GRACE PERIOD from joins (#8028)" This reverts commit c17ce67. * Revert "chore: revert call to ofTimeAndGracePeriod() (#8047)" This reverts commit 4c54980.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts the GRACE PERIOD syntax from stream-stream joins. There's an issue with the new semantics (see apache/kafka#11235) that's need to be fixed first.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist