Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick commits to revert GRACE PERIOD syntax #8050

Merged
merged 2 commits into from
Aug 24, 2021
Merged

chore: cherry-pick commits to revert GRACE PERIOD syntax #8050

merged 2 commits into from
Aug 24, 2021

Conversation

spena
Copy link
Member

@spena spena commented Aug 24, 2021

Description

This PR cherry-picked the following commits on the 7.0.x branch
#8028
#8047

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena requested a review from a team August 24, 2021 18:57
vvcephei
vvcephei approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a cursory look, and it seems right.

vvcephei
vvcephei approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Felt guilty about that cursory glance, so I also just compared the diff visually with the diffs of the two PRs on master.

@spena spena merged commit 4946003 into 7.0.x Aug 24, 2021
@spena spena deleted the 7.0.x_revert_grace_period branch August 24, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvcephei vvcephei vvcephei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spena @vvcephei