chore: add key_schema_id and value_schema_id to format properties #8185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaosky
force-pushed
the
refactor-property
branch
from
ee9d01b
to
7f12e81
Compare
lihaosky
changed the title
lihaosky
force-pushed
the
refactor-property
branch
from
b2bfafb
to
beff574
Compare
lihaosky
force-pushed
the
refactor-property
branch
3 times, most recently
from
1589b56
to
bd0b22d
Compare
lihaosky
force-pushed
the
refactor-property
branch
from
e8e8eee
to
c6558bc
Compare
lihaosky
force-pushed
the
refactor-property
branch
from
d12257b
to
72ea4a3
Compare
lihaosky
changed the title
mjsax
approved these changes
Oct 20, 2021
| @@ -299,7 +311,12 @@ private void compare( | |||
| ) { | |||
| final Object expected = extractStatement.apply(statement, config); | |||
| final Object actual = extractSource.apply(dataSource); | |||
| if (!actual.equals(expected)) { | |||
|
|
|||
| if (actual == null && expected == null) { | |||
There was a problem hiding this comment.
Do we need this check? IIRC Objects.equals(null,null) is a valid call and it will return true?
Nice catch on the NPE issue though!
mjsax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on #8177. Review after this commit: c760b58.
key_schema_idandvalue_schema_idtoCommonCreateConfigsince the property will be used byC*ASas well asCREATE WITHcommand later.schema_idproperty in format properties so that it can be used to choose translation policy (i.e. uppercase field name or not uppercase them) see refactor: Refactor ConnectFormatSchemaTranslator to take translator object instead of lamda function so that the translator can take in config to decide how to transform field names #8177, chore: add options to control field name case in schema translation #8213.*schema_idto YATT test.Test done