Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make HEADER and HEADERS non-reserved #8490

Merged
merged 2 commits into from
Dec 14, 2021
Merged

fix: make HEADER and HEADERS non-reserved #8490

merged 2 commits into from
Dec 14, 2021

Conversation

jzaralim
Copy link
Contributor

Description

Fixes #8446

Testing done

Changed some QTTs to use these as column names

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner December 10, 2021 19:11
@jzaralim jzaralim requested a review from spena December 10, 2021 19:11
guozhangwang
guozhangwang approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzaralim jzaralim merged commit c8c4438 into confluentinc:master Dec 14, 2021
@jzaralim jzaralim deleted the fix branch December 14, 2021 07:11
@agavra agavra mentioned this pull request Jan 13, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

@guozhangwang guozhangwang guozhangwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column name 'headers' throws an error that it is reserved name
3 participants
@jzaralim @spena @guozhangwang