fix: add GRACE and PERIOD to the nonReserved and automate testing #8596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guozhangwang
approved these changes
Jan 13, 2022
|
@guozhangwang yup - we should almost never change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #8591 and also adds a test to make sure we don't accidentally add more words to the reserved list and make these kind of breaking changes
(see also #8490 for context)
Testing done
The meta-test that this adds iterates the entire vocabulary and makes sure that the words are either reserved explicitly or part of the nonReserved rule.
Reviewer checklist