fix: reject incorrectly typed HEADER columns #8511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Dec 15, 2021
| @@ -91,6 +95,9 @@ public LogicalSchema toLogicalSchema() { | |||
| if (tableElement.getConstraints().isKey() || tableElement.getConstraints().isPrimaryKey()) { | |||
| builder.keyColumn(fieldName, fieldType); | |||
| } else if (tableElement.getConstraints().isHeaders()) { | |||
| throwOnIncorrectHeaderColumnType( | |||
There was a problem hiding this comment.
I think this check should be done earlier in the AstBuilder where the TableElement is created. My opinion is that once TableElement is created, then toLogicalSchema shouldn't fail. This method just converts from one object to another (unsure why isEmpty() fails, but it's already there). Also, the AstBuilder may check for invalid syntax, so why I think it should live there. What do you think?
There was a problem hiding this comment.
That makes sense. Moved.
added 2 commits
December 15, 2021 09:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8447
Throws an error if a user tries to create a source with a HEADER column with an incorrect type
Testing done
QTT and unit tests
Reviewer checklist