Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for connect specific https configs #8553

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Dec 28, 2021

Description

Fixes #6631.

This PR adds support for TLS configs to configure ksqlDB requests to an external Connect deployment. Configs prefixed with ksql.connect. are applied only to ksqlDB's Connect client. Non-prefixed configs are also applied to ksqlDB's Connect client by default, similar to how ksqlDB handles its Schema Registry TLS configs today.

Example configs:

ksql.connect.url=https://localhost:8443
ksql.connect.ssl.truststore.location=/path/to/client.truststore.jks
ksql.connect.ssl.truststore.password=<some password here>
ksql.connect.ssl.truststore.type=JKS
ksql.connect.ssl.endpoint.identification.algorithm=none

Testing done

I wanted to add an integration test but hit a few dead ends trying to configure an embedded Connect with custom TLS configs. Open to ideas if anyone has any, else I think the change is minor enough that I feel good about the unit tests plus my manual test coverage.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner December 28, 2021 23:49
Copy link
Contributor

@jzaralim jzaralim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcrfxia vcrfxia force-pushed the connect-https-configs-7.1.x branch from d96a18b to eeced37 Compare January 6, 2022 23:48
@vcrfxia vcrfxia changed the base branch from 7.1.x to master January 6, 2022 23:48
@vcrfxia vcrfxia merged commit fe25f3a into confluentinc:master Jan 7, 2022
@vcrfxia vcrfxia deleted the connect-https-configs-7.1.x branch January 7, 2022 22:21
@reneveyj
Copy link

reneveyj commented May 3, 2022

Thanks for adding this. Now I can finally manage connectors from the ksql CLI :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External Connect integration over HTTPS doesn't work
4 participants