Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use topology-specific IQ APIs #8674

Closed
wants to merge 1 commit into from
Closed

fix: use topology-specific IQ APIs #8674

wants to merge 1 commit into from

Conversation

jnh5y
Copy link
Member

@jnh5y jnh5y commented Jan 28, 2022

This is a rebase of #8579 to resolve merge conflicts and get a green build!

@jnh5y
fix: use topology-specific IQ APIs
2406d06 
fix: get ksql compiling again by removing all usages of the internal StreamsMetadataImpl.NOT_AVAILABLE variable which was just deleted upstream in AK
@jnh5y jnh5y requested a review from a team as a code owner January 28, 2022 15:33
@jnh5y jnh5y mentioned this pull request Jan 28, 2022
Closed
@jnh5y
Copy link
Member Author

jnh5y commented Jan 28, 2022

CI is failing with

10:54:36  [ERROR] io.confluent.ksql.execution.streams.materialization.ks.KsStateStoreTest.shouldUseNamedTopologyWhenSharedRuntimeIsEnabled  Time elapsed: 0.057 s  <<< FAILURE!
...
10:54:38  [ERROR] Failures: 
10:54:38  [ERROR]   KsStateStoreTest.shouldUseNamedTopologyWhenSharedRuntimeIsEnabled:107 ```

Does anyone know what to do / change to fix this?

@wcarlson5
Copy link
Contributor

@jnh5y its hard to tell from the output you give, but I don't see that you have updated KsStateStoreTest. This issue was that the type we were checking was specify but the test class had use a parent type so they didn't match

@jnh5y jnh5y closed this Jan 28, 2022
@jnh5y jnh5y deleted the rebase-use-all-NamedTopology-specific-IQ-methods branch March 15, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guozhangwang guozhangwang guozhangwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnh5y @wcarlson5 @guozhangwang