Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register state listener after restarting runtime #9032

Merged
merged 2 commits into from
Apr 14, 2022
Merged

fix: register state listener after restarting runtime #9032

merged 2 commits into from
Apr 14, 2022

Conversation

wcarlson5
Copy link
Contributor

Description

When restarting the runtime we need to register the state change listener for the new runtime.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@wcarlson5 wcarlson5 requested a review from a team as a code owner April 13, 2022 22:28
@CLAassistant
Copy link

CLAassistant commented Apr 13, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha. Good catch. LGTM

@wcarlson5 wcarlson5 merged commit 1f7a09a into confluentinc:master Apr 14, 2022
@wcarlson5 wcarlson5 deleted the state_listener_quick_fix branch April 14, 2022 20:31
wcarlson5 added a commit that referenced this pull request May 19, 2022
* fix: register state listener after restarting runtime

(cherry picked from commit 1f7a09a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants