fix: use internal topic config for transient queries too #9393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walker Carlson <wcarlson@confluent.io>
ableegoldman
approved these changes
Aug 5, 2022
rodesai
pushed a commit
to rodesai/ksql
that referenced
this pull request
Aug 6, 2022
…c#9393) For when shared runtimes are on we should use the internal topics prefix for transient queries as well.
rodesai
added a commit
to rodesai/ksql
that referenced
this pull request
Aug 9, 2022
…c#9393) (confluentinc#9398) For when shared runtimes are on we should use the internal topics prefix for transient queries as well. Co-authored-by: Walker Carlson <18128741+wcarlson5@users.noreply.github.com>
mapr-devops
pushed a commit
to mapr/ksql
that referenced
this pull request
Aug 10, 2022
* fix: use internal topic config for transient queries too (confluentinc#9393) For when shared runtimes are on we should use the internal topics prefix for transient queries as well. * fix: compare topics not sources (confluentinc#9388) * Check source topics instead of sources * Check source topics instead of sources * Don't turn on the flag yet * review comments Signed-off-by: Walker Carlson <wcarlson@confluent.io> * Update ksqldb-engine/src/main/java/io/confluent/ksql/engine/RuntimeAssignor.java Co-authored-by: Victoria Xia <victoria.f.xia281@gmail.com> * update name Signed-off-by: Walker Carlson <wcarlson@confluent.io> * update name Signed-off-by: Walker Carlson <wcarlson@confluent.io> Co-authored-by: Victoria Xia <victoria.f.xia281@gmail.com> * fix: make sure to close clients from precondition checker (confluentinc#9391) * fix: make sure to close clients from precondition checker * add missing config from integration test Co-authored-by: Steven Zhang <stevenz@confluent.io> * fix: move udf loading to run before the precondition checker (confluentinc#9392) * fix: move udf loading to run before the precondition checker moves udf loading to run before the precondition checker. this ensures we can quickly start the main server once the precondition checker is completed running. Also adds a metric to measure server start time * missing log * fix rest app in integration test * fix spotbugs Co-authored-by: Steven Zhang <stevenz@confluent.io> * fix: fix regex used to extract queryId from threadId metrics tag (confluentinc#9394) * WIP * checkstyle * fix up storage utilization metrics tests * update consumer member tag name after rebas to fix tests Co-authored-by: Walker Carlson <18128741+wcarlson5@users.noreply.github.com> Co-authored-by: Victoria Xia <victoria.f.xia281@gmail.com> Co-authored-by: Rohan <desai.p.rohan@gmail.com> Co-authored-by: Steven Zhang <stevenz@confluent.io> Co-authored-by: A. Sophie Blee-Goldman <sophie@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Walker Carlson wcarlson@confluent.io
Description
For when shared runtimes are on we should use the internal topics prefix for transient queries as well.
Testing done
run with the shared runtimes turned on
Reviewer checklist