fix: apply custom error handler to KsqlStatementException (MINOR) #9442
+56
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The custom error handler in KsqlResource is currently only applied to raw exceptions and KsqlExceptions, but not KsqlStatementExceptions. This means the error handler misses cases such as when Schema Registry is not enabled, because the DefaultSchemaInjector has logic to wrap the KsqlException in a KsqlStatementException.
We could fix this by not having injectors (and other parts of the code) wrap KsqlExceptions, but it seems better to leave that flexibility and instead apply the error handler to KsqlStatementExceptions from KsqlResource. At least, I see no reason not to.
Testing done
Added unit tests.
Reviewer checklist