Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASL IO loop does not detect disconnects on Windows #1937

Closed
edenhill opened this issue Aug 12, 2018 · 6 comments · Fixed by #2032
Closed

SASL IO loop does not detect disconnects on Windows #1937

edenhill opened this issue Aug 12, 2018 · 6 comments · Fixed by #2032
Labels

Comments

@edenhill
Copy link
Contributor

As described in confluentinc/confluent-kafka-dotnet#285 (comment)

@edenhill edenhill added the bug label Aug 12, 2018
@edenhill edenhill changed the title SASL IO loop does not detect disconnects SASL IO loop does not detect disconnects on Windows Aug 24, 2018
edenhill added a commit that referenced this issue Aug 24, 2018
..and try to persist errnos (for internal use) on receive error.
edenhill added a commit that referenced this issue Aug 27, 2018
..and try to persist errnos (for internal use) on receive error.
@stefanseufert
Copy link
Contributor

I've seen that your fix went into 0.11.6-RC3. I tested this version today (using the pre release nuget packages for both rdkafka and the .net client). Sadly I've got to report that the issue still remains.

I'd be happy to help with fixing this issue but currently I'm not able to build the solution. I alwyas get linker errors, saying that external symbols such as _ictest and _sscanf, __iob_func cannot be resolved. The source seems to be (partially?) in openssl, but I am using the version mentioned in the readme. Any directions regarding this issue?

@edenhill
Copy link
Contributor Author

edenhill commented Oct 1, 2018

@stefanseufert That happens when trying to link OpenSSL (with an older msvc toolchain, 120) statically on a newer Visual Studio (toolchain 140).
The fix is to change the occurences of c:\OpenSSL...\libs\vc\static\ in win32/librdkafka.vcxproj by removing the static\ suffix.

@stefanseufert
Copy link
Contributor

@edenhill Thank you, changing the directory made my build work (the interceptor test project still fails, but I simply excluded this for now).

I'll try to pinpoint the issue (most probably this afternoon) and will keep you posted.

@stefanseufert
Copy link
Contributor

The cause was even simpler than assumed in my original analysis. The poll result was not checked for the disconnect flag (POLLHUP) while in AUTH state. The pull request above adds a check for this case in the same way the situation is handled for the UP state.

@WolfspiritM
Copy link

I'm also waiting for a fix to this!
The RC didn't seem to fix it so I hope this can be integrated into the final 0.11.6.
It doesn't seem to be a big change.

Thanks @stefanseufert

@OMSKremer
Copy link

Yeah, please integrate it in v0.11.6 and do not wait for version 1.0.0, it's a really nasty problem!

Thx @stefanseufert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants