[KIP-580] Exponential Backoff with Mock Broker Changes to Automate Testing. #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
milindl
requested changes
Sep 18, 2023
There was a problem hiding this comment.
General comments:
- Change INTRODUCTION.md to update list of supported KIPs.
- Change INTRODUCTION.md section "Producer message delivery failure" and mention retry.backoff.max.ms as well.
- Update CHANGELOG.md accordingly.
- There are a whole lot of memory leaks in the tests, fix them. At the very least, clean up the resources you're creating (the request lists, partition lists, duplicated configs etc) if you can't run valgrind. Any subsequent memory leaks I can run valgrind on the test to find out.
- Run make style-fix on the code. If you have difficulty doing that with macOS, I can do that once you've made all the other changes.
- Fix the warnings. Lots of warnings are there while compiling.
milindl
reviewed
Sep 25, 2023
milindl
requested changes
Sep 25, 2023
|
Some notes for test failures: 0090: the backoff for each message in a batch needs to be the same, currently it's different due to jitter. In rd_kafka_retry_msgq calculate jitter just once and use it for each message. |
|
And besides this, please increase the timeout for 0143. |
emasab
changed the title
mahajanadhitya
force-pushed
the
feature/KIP-580
branch
from
8e65bf5
to
ca3d17f
Compare
mahajanadhitya
force-pushed
the
feature/KIP-580
branch
from
ca3d17f
to
4be041f
Compare
emasab
requested changes
Sep 28, 2023
emasab
requested changes
Sep 28, 2023
emasab
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Awesome PR @mahajanadhitya @milindl ! This is a big improvement.
milindl
force-pushed
the
feature/KIP-580
branch
from
9984ad7
to
cd5d802
Compare
milindl
approved these changes
Sep 29, 2023
7 tasks
axelandersson
added a commit
to axelandersson/librdkafka
that referenced
this pull request
Oct 5, 2023
* upstream/master: librdkafka v2.3.0 (confluentinc#4455) Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (confluentinc#4438) Move can_q_contain_fetched_msgs inside q_serve (confluentinc#4431) [KIP-580] Exponential Backoff with Mock Broker Changes to Automate Testing. (confluentinc#4422) Update only the mklove version of OpenSSL to 3.0.11 (confluentinc#4454) Permanent errors during offset validation should be retried (confluentinc#4447) Increased flexver request size for Metadata request to include topic_id size (confluentinc#4453) Fix loop of OffsetForLeaderEpoch requests on quick leader changes (confluentinc#4433) Fix for stored offsets not being committed if they lacked the leader epoch (confluentinc#4442) Add leader epoch to control messages (confluentinc#4434) Refactored tmpabuf and fixed an insufficient buffer allocation (confluentinc#4449) Work around KIP-700 restrictions for DescribeCluster [KIP-430] [admin] KIP-430: Add authorized operations to describe API Fix segfault if assignor state is NULL, (confluentinc#4381)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.