Fix hang in incremental assign during close #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emasab any mitigation possible before it is released? |
5 tasks
milindl
approved these changes
Apr 18, 2024
CHANGELOG.md
Outdated
| * While using the cooperative assignor, given an assignment is received while closing the consumer | ||
| it's possible that it gets stuck in state WAIT_ASSIGN_CALL, while the method is converted to | ||
| a full unassign. Solved by changing state from WAIT_ASSIGN_CALL to WAIT_UNASSIGN_CALL | ||
| while doing this conversion (#). |
There was a problem hiding this comment.
Suggested change
| while doing this conversion (#). | |
| while doing this conversion (#4528). |
|
Still some merge conflicts in the changelog but please merge whenever required before/after merging other stuff. Change makes sense to me. |
emasab
force-pushed
the
dev_fix_hang_incremental_assign_during_close
branch
from
28ef97a
to
4c69eb8
Compare
because of an assignment op during consumer close
emasab
force-pushed
the
dev_fix_hang_incremental_assign_during_close
branch
from
4c69eb8
to
17f8e81
Compare
milindl
approved these changes
Apr 18, 2024
|
Rebased, fix was already included in 848 so have left the CHANGELOG only and a change to TEST_CONSUMER_GROUP_PROTOCOL until we merge #4662 |
anchitj
pushed a commit
that referenced
this pull request
Jun 10, 2024
While using the cooperative assignor, given an assignment is received while closing the consumer it's possible that it gets stuck in state WAIT_ASSIGN_CALL, while the method is converted to a full unassign. Solved by changing state from WAIT_ASSIGN_CALL to WAIT_UNASSIGN_CALL while doing this conversion. Closes #4527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the cooperative assignor, given an assignment is received while closing the consumer
it's possible that it gets stuck in state WAIT_ASSIGN_CALL, while the method is converted to
a full unassign. Solved by changing state from WAIT_ASSIGN_CALL to WAIT_UNASSIGN_CALL
while doing this conversion.
Fixes #4527