Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce upgrade to flexver plus tests #4595

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Conversation

anchitj
Copy link
Member

@anchitj anchitj commented Jan 29, 2024

No description provided.

@anchitj anchitj force-pushed the dev_produce_flexver_test branch 3 times, most recently from 8ce92e2 to 88f8694 Compare January 30, 2024 07:07
@anchitj anchitj force-pushed the dev_produce_kip_467_test branch 2 times, most recently from 733f3c8 to c90c919 Compare January 30, 2024 07:22
@anchitj anchitj marked this pull request as ready for review February 13, 2024 07:40
@anchitj anchitj force-pushed the dev_produce_kip_467_test branch 2 times, most recently from 1189944 to 2e2091c Compare March 20, 2024 08:45
Base automatically changed from dev_produce_kip_467_test to master April 15, 2024 13:13
@emasab emasab changed the title Dev produce flexver test Produce upgrade to flexver plus tests May 14, 2024
src/rdkafka_request.c Outdated Show resolved Hide resolved
@emasab
Copy link
Collaborator

emasab commented Jun 5, 2024

Please rebase on feature/fetch-951-prework-v13+ and use rd_kafka_buf_write_tags_empty
In rd_kafka_mock_connection_read_request use rd_kafka_buf_skip_str_no_flexver here:

/* For convenience, shave off the ClientId */

@emasab
Copy link
Collaborator

emasab commented Jun 5, 2024

Upgrade Produce mock handler to 9 in this PR

@anchitj anchitj requested a review from a team as a code owner June 10, 2024 09:45
@anchitj
Copy link
Member Author

anchitj commented Jun 10, 2024

Rebased with https://github.com/confluentinc/librdkafka/pull/4584/files and addressing comments

Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anchitj ! last few changes for this PR

src/rdkafka_mock_handlers.c Show resolved Hide resolved
src/rdkafka_mock_handlers.c Outdated Show resolved Hide resolved
* 0 record errors for now */
rd_kafka_buf_write_arraycnt(resp, 0);

/* error_message */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* error_message */
/* Response: ErrorMessage */

src/rdkafka_mock_handlers.c Outdated Show resolved Hide resolved
src/rdkafka_mock_handlers.c Outdated Show resolved Hide resolved
src/rdkafka_mock_handlers.c Outdated Show resolved Hide resolved
@anchitj anchitj mentioned this pull request Jun 12, 2024
@emasab emasab force-pushed the dev_produce_flexver_test branch 2 times, most recently from 4f972fb to 58c676e Compare June 12, 2024 17:13
Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have rebased, just a few changes and we're done

src/rdkafka_mock_handlers.c Show resolved Hide resolved
src/rdkafka_mock_handlers.c Outdated Show resolved Hide resolved
INTRODUCTION.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@emasab emasab merged commit 6b13a7b into master Jun 13, 2024
2 checks passed
@emasab emasab deleted the dev_produce_flexver_test branch June 13, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants