-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce upgrade to flexver plus tests #4595
Conversation
172d5bb
to
4508cb4
Compare
c22ba01
to
c749124
Compare
8ce92e2
to
88f8694
Compare
733f3c8
to
c90c919
Compare
1189944
to
2e2091c
Compare
1ac97a2
to
3dbcd30
Compare
Please rebase on Line 1108 in 465f81c
|
Upgrade Produce mock handler to 9 in this PR |
9cd44a8
to
09d6d7e
Compare
Rebased with https://github.com/confluentinc/librdkafka/pull/4584/files and addressing comments |
09d6d7e
to
0984b75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anchitj ! last few changes for this PR
src/rdkafka_mock_handlers.c
Outdated
* 0 record errors for now */ | ||
rd_kafka_buf_write_arraycnt(resp, 0); | ||
|
||
/* error_message */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* error_message */ | |
/* Response: ErrorMessage */ |
0984b75
to
55305b9
Compare
4f972fb
to
58c676e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
58c676e
to
9c73607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have rebased, just a few changes and we're done
78d8fe0
to
1224b57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM
No description provided.