Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIP 951 - Phase 1 #4613

Merged
merged 10 commits into from
Jun 14, 2024
Merged

KIP 951 - Phase 1 #4613

merged 10 commits into from
Jun 14, 2024

Conversation

anchitj
Copy link
Member

@anchitj anchitj commented Feb 7, 2024 •
edited
Loading

@anchitj anchitj changed the title Dev parse flexver tags KIP 951 - Phase 1 Feb 7, 2024
@anchitj anchitj marked this pull request as ready for review May 16, 2024 14:05
emasab
emasab requested changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@emasab emasab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just so minor changes. Please rebase

src/rdkafka_buf.h Outdated Show resolved Hide resolved
src/rdkafka_request.c Outdated Show resolved Hide resolved
@anchitj anchitj requested a review from a team as a code owner June 12, 2024 11:11
@anchitj
Copy link
Member Author

anchitj commented Jun 12, 2024 •
edited
Loading

Rebased on top of #4595

@anchitj anchitj force-pushed the dev_parse_flexver_tags branch 2 times, most recently from 9739010 to 25ab3f9 Compare June 13, 2024 05:31
mahajanadhitya and others added 7 commits June 13, 2024 13:54
@mahajanadhitya @anchitj
[KIP-951] Prework: upgrade to v15
899ffd3
@emasab @anchitj
[KIP-951] Prework: upgrade to v15
b4dcace 
- Style fix
- RPC version update
- Fix uninitialized value
  and topic name from rkt
- Revert newline changes
- Remove duplicate declaration
- Rename rd_kafka_buf_write_tags
  to rd_kafka_buf_write_tags_empty
  before implementing the define
  that allows to write tags
- Upgrade fetch mock handler to v15
- devel assertion and logging improvements
@anchitj
Fix response parsing
ebcc250
@anchitj
Make rd_kafka_buf_skip_str generic
d399873
@anchitj
PR feedback
68422dc
@emasab @anchitj
flexver tags parser function
2033c85
@anchitj
Add common structs
56bc2aa
emasab
emasab requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes that will be needed for next commits

src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_proto.h Outdated Show resolved Hide resolved
src/rdkafka_request.c Show resolved Hide resolved
src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_buf.h Outdated Show resolved Hide resolved
src/rdkafka_buf.h Outdated Show resolved Hide resolved
src/rdkafka_buf.h Show resolved Hide resolved
emasab
emasab requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few changes

src/rdkafka_request.h Show resolved Hide resolved
src/rdkafka_buf.h Outdated Show resolved Hide resolved
src/rdkafka_proto.h Outdated Show resolved Hide resolved
emasab
emasab approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emasab emasab merged commit 6db3c03 into master Jun 14, 2024
2 checks passed
@emasab emasab deleted the dev_parse_flexver_tags branch June 14, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anchitj @emasab @mahajanadhitya