Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloading specific version of schemas capability added #2178

Merged
merged 5 commits into from
Feb 25, 2022
Merged

Downloading specific version of schemas capability added #2178

merged 5 commits into from
Feb 25, 2022

Conversation

pagrawal10
Copy link
Contributor

Objective : To download a specific version associated with a subjectPattern.

To run:

mvn io.confluent:kafka-schema-registry-maven-plugin:7.2.0-0:download

Parameters to be passed while using this goal :

  • schemaRegistryUrls
    Type : List
    Required = true

  • outputDirectory
    Type : File
    Required = true

  • versions
    Type : List
    Required = true

  • subjectPatterns
    Type : List
    Required = true

@rayokota
Copy link
Member

rayokota commented Feb 15, 2022 •
edited
Loading

Thanks @pagrawal10 , the new functionality should be backward compatible. Won't this break users who are not specifying any versions?

rayokota
rayokota reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some more comments. Also can you add unit tests DownloadSchemaRegistryMojoTest?

...plugin/src/main/java/io/confluent/kafka/schemaregistry/maven/DownloadSchemaRegistryMojo.java Show resolved Hide resolved
...plugin/src/main/java/io/confluent/kafka/schemaregistry/maven/DownloadSchemaRegistryMojo.java Show resolved Hide resolved
...plugin/src/main/java/io/confluent/kafka/schemaregistry/maven/DownloadSchemaRegistryMojo.java Show resolved Hide resolved
...plugin/src/main/java/io/confluent/kafka/schemaregistry/maven/DownloadSchemaRegistryMojo.java Show resolved Hide resolved
...plugin/src/main/java/io/confluent/kafka/schemaregistry/maven/DownloadSchemaRegistryMojo.java Show resolved Hide resolved
rayokota
rayokota approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise LGTM

...plugin/src/main/java/io/confluent/kafka/schemaregistry/maven/DownloadSchemaRegistryMojo.java Outdated Show resolved Hide resolved
@pagrawal10 pagrawal10 merged commit 21fed5a into master Feb 25, 2022
@gayanW gayanW mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayokota rayokota rayokota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pagrawal10 @rayokota