Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.0.0-SNAPSHOT and Kafka dependency to 0.10.0.0-SNAPSHOT #298

Merged
merged 1 commit into from
Mar 4, 2016

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented Mar 4, 2016

No description provided.

@ewencp
Copy link
Contributor Author

ewencp commented Mar 4, 2016

@miguno @ijuma @gwenshap @norwood Updating versions to clean up issues with system tests to address some issues in confluentinc/muckrake#90. Personally verified on that PR that it fixes issues w/ incompatible changes. These changes will be required for release anyway, modulo the SNAPSHOT suffix. Note that this upgrades all deps to 0.10.0.0-SNAPSHOT. Previous discussion left it unclear whether we might want to depend on older versions in some cases, but it simplifies things for now if we maintain one version across all packages.

Depends on confluentinc/rest-utils#33

@@ -179,7 +179,7 @@ generating
Requirements
------------

- Kafka: 0.9.0.1 (0.9.0.1-cp1 recommended)
- Kafka: 0.10.0.0-SNAPSHOT (0.10.0.0-SNAPSHOT recommended)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommended bit is a bit weird, but maybe OK to leave as we will need that when we release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the intent here was just to keep the format so when we update to 0.10.0.0, possibly w/ a -cpX postfix, we'll make sure to emphasize what we recommend.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@ijuma
Copy link
Member

ijuma commented Mar 4, 2016

LGTM. Left one comment, but not sure it's worth addressing.

ewencp added a commit that referenced this pull request Mar 4, 2016
Bump version to 3.0.0-SNAPSHOT and Kafka dependency to 0.10.0.0-SNAPSHOT
@ewencp ewencp merged commit 04d4923 into master Mar 4, 2016
@ewencp ewencp deleted the bump-version-3.0.0-kafka-0.10 branch March 4, 2016 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants