Check X connection and terminate when it is gone. #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix works for me. |
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Dec 19, 2021
Fix proposed to upstream in PR conformal/spectrwm#478 ok bket@
|
ping after on year (almost) :-) |
|
Looks like this has been fixed by 987b2ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The X connection is never explicitly checked in the main loop. When the X connection is terminated, spectrwm keeps running.
Unfortunately the bar update logic does a call (https://github.com/conformal/spectrwm/blob/master/spectrwm.c#L2611) which leads to the termination of spectrwm. So while the bar is shown, killing X also leads spectrwm to terminate. If the bar is not shown, this call is not made and spectrwm kept running. This masked the issue.
Fixes: #474
In this PR I check the X connection explicitly in the main loop. However,
xcb_flush(conn)is called various times and it returns<= 0on failure. This could be used to detect connection issues as well.