fix: Allocate new slice for each batch in streaming reader

Related to milvus-io#33268 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia · May 24, 2024 · d0577cc · d0577cc
1 parent 3c7d020
commit d0577cc
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/internal/storage/serde.go b/internal/storage/serde.go
@@ -588,9 +588,8 @@ func (deser *DeserializeReader[T]) Next() error {
 		deser.pos = 0
 		deser.rec = deser.rr.Record()
 
-		if deser.values == nil {
-			deser.values = make([]T, deser.rec.Len())
-		}
+		// allocate new slice preventing overwrite previous batch
+		deser.values = make([]T, deser.rec.Len())
 		if err := deser.deserializer(deser.rec, deser.values); err != nil {
 			return err
 		}