Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge homebrew support #558

Merged
merged 13 commits into from May 26, 2023
Merged

merge homebrew support #558

merged 13 commits into from May 26, 2023

Conversation

ott2
Copy link
Collaborator

@ott2 ott2 commented Apr 11, 2023

This is now worth considering. I added a minimalist formula, some fixes to the original cask, expanded the readme, and fixed an unrelated syntax error in one of the install scripts which blocks the formula build.

  • This perhaps needs testing on Linux.
  • The JDK dependency seems really messy but should be at least mentioned somehow in the documentation and ideally declared in both the cask and formula.
  • I would ideally also like to use stack and a GHC installed by brew instead of running a binary to install stack, but that will probably have to wait until Conjure moves to Haskell 9.x since the 8.x releases in brew aren't being maintained.
  • See also the todo and caveats in the readme.

@ott2 ott2 requested a review from ozgurakgun May 25, 2023 23:32
@ozgurakgun ozgurakgun merged commit 978e892 into main May 26, 2023
3 checks passed
@ozgurakgun ozgurakgun deleted the homebrew branch November 8, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants